View Issue Details

IDProjectCategoryLast Update
0027648AI War 2Crash/ExceptionNov 23, 2022 5:44 pm
ReporterDismiss Assigned To 
Status newResolutionopen 
Product Version5.527 
Summary0027648: factions still called after disabling mod
DescriptionMods containing external factions still receive at least some calls to those factions, after disabling the entire mod and starting a new game in the same run. Specifically "DoRefreshFromFactionSettings" gets called constantly while in game.
TagsNo tags attached.



Nov 23, 2022 3:10 pm

developer   ~0067359

The same was true for external faction and worldinfo, which is why AMU was erroring out after it was disabled: The code-bits remained, but had no more XML bits to relate to.
I settled for putting a check "is this mod enabled" into all the threads of my external faction and worldinfo implementations, because upsetting the codebase and potentially producing bugs seemed like a bad idea.


Nov 23, 2022 5:44 pm

developer   ~0067360

I've hit this with multiple of my mods multiple times. I feel like making these calls on unenabled mods both makes no sense and is its own source of potentially impossible to reproduce bugs (because the save game doesn't have information like, i had this other mod on in the game before).

I only went far enough to check for some obvious "is this external faction suppose to be enabled" method or field or property and didn't see one. @Badger or @Chris, Thoughts on this?

Issue History

Date Modified Username Field Change
Nov 23, 2022 2:51 pm Dismiss New Issue
Nov 23, 2022 3:10 pm NRSirLimbo Note Added: 0067359
Nov 23, 2022 5:44 pm Dismiss Note Added: 0067360