View Issue Details

IDProjectCategoryLast Update
0027008AI War 2Bug - GameplayApr 19, 2022 9:49 am
ReporterMatt Dyer Assigned ToChris_McElligottPark  
Severitymajor 
Status resolvedResolutionfixed 
Product Version4.021 Scourge Of A Beacon 
Fixed in Version4.024 Graveyard Digger 
Summary0027008: Thread stalling issue (with Dump Threads Run)
DescriptionAround mid-late game, started having things stall out with an alert about various background processes not updating for 4-15 seconds. Things would resume for a moment and then stop again. I ran the debug process logger and process killer and copied the log file. Quitting and reloading save got things back to normal.
TagsNo tags attached.

Activities

Matt Dyer

Apr 17, 2022 9:48 am

reporter  

ArcenDebugLog.txt (935,747 bytes)

Chris_McElligottPark

Apr 18, 2022 9:42 pm

administrator   ~0066124

Okay, this is very interesting. I think that this is not at all the sort of thing we've been seeing elsewhere. Essentially, the core problem here is that the central dictionary of things-that-have died (most notably shots in this case) is getting monstrously huge, and taking a long time to parse.

I should be able to mitigate this a lot by simply making it not really track that sort of thing for shots (wow does it not matter), since that's the thing that grows fastest. But then also for the ships, I think I can basically make it just clear out old entries. I had wondered a while back if this would be needed, but I didn't want to borrow trouble if it didn't seem to be an issue. Not it's clearly an issue.

Chris_McElligottPark

Apr 19, 2022 9:48 am

administrator   ~0066129

Thank you! This should be fixed now:

* Added a notable performance improvement for games that have been running for a long while without reloading or closing the game or going back to the main menu, especially when there are a lot of shots being fired.
** As part of this, also adjusted how our central dictionaries are handled for shots, ships, and wormholes, and thus have removed any chance that a deadlock was resulting from them.
** Thanks to Matt Dyer for the "thread stalling" report, which was the performance issue in question. Without the thread dump from him, this would never have been found!

Issue History

Date Modified Username Field Change
Apr 17, 2022 9:48 am Matt Dyer New Issue
Apr 17, 2022 9:48 am Matt Dyer File Added: ArcenDebugLog.txt
Apr 17, 2022 12:37 pm BadgerBadger Assigned To => Chris_McElligottPark
Apr 17, 2022 12:37 pm BadgerBadger Status new => assigned
Apr 17, 2022 12:37 pm BadgerBadger Sticky Issue No => Yes
Apr 17, 2022 12:37 pm BadgerBadger Summary Thread stalling issue => Thread stalling issue (with Dump Threads Run)
Apr 18, 2022 9:42 pm Chris_McElligottPark Note Added: 0066124
Apr 18, 2022 9:42 pm Chris_McElligottPark Status assigned => confirmed
Apr 19, 2022 9:48 am Chris_McElligottPark Status confirmed => resolved
Apr 19, 2022 9:48 am Chris_McElligottPark Resolution open => fixed
Apr 19, 2022 9:48 am Chris_McElligottPark Fixed in Version => 4.024 Graveyard Digger
Apr 19, 2022 9:48 am Chris_McElligottPark Note Added: 0066129
Apr 19, 2022 9:49 am Chris_McElligottPark Sticky Issue Yes => No