View Issue Details

Jump to NotesJump to History
IDProjectCategoryDate SubmittedLast Update
0025688AI War 2Bug - OtherOct 27, 2021 10:20 amNov 8, 2021 4:54 pm
ReporterRocketAssistedPuffin Assigned Totom.prince  
Status resolvedResolutionfixed 
Product VersionBeta 3.712 Loading Hotfix 
Summary0025688: Galaxy wide build cap feature seems to only works for Fleet Leaders.
DescriptionFound something in Window_InGameSidebarDirectBuild. The code for this appears to work only for Fleet Leaders, and any UI code is commented out.

                        if ( this.BuildTypeData.TypeData.IsFleetLeader )
                        {
                            fullCap = this.BuildTypeData.TypeData.GalaxyWideCapForPlayersConstructing;
                            if ( fullCap < 1 )
                                fullCap = 1;

                            int countOfExisting = 0;
                            this.BuildTypeData.Fleet.Faction.DoForEntities( EntityRollupType.HasGalaxyWideCapForPlayersConstructing, delegate ( GameEntity_Squad squad )
                            {
                                if ( squad.TypeData == this.BuildTypeData.TypeData )
                                    countOfExisting++;
                                return DelReturn.Continue;
                            } );

                            builtCount = countOfExisting;
                        }
                        else
                        {
                            builtCount = this.BuildTypeData.GetCountPresent( true, ExtraFromStacks.IncludePrecalc );
                            if ( builtCount < 0 )
                                builtCount = 0;
                        }
TagsNo tags attached.

Relationships

related to 0025390 resolvedtom.prince Zenith trader station-keeper counter is not galaxy wide 

Activities

tom.prince

Nov 2, 2021 6:27 pm

developer   ~0063153

It looks like this is only a UI issue; the code in FleetMembership will prevent you from building more than the galaxy wide cap.

You can test this with the Zenith trader, by increasing the fleetmembersip cap of the `ZenithPurchases` of something higher than the galaxy wide cap.

That said, the UI should be fixed.

RocketAssistedPuffin

Nov 7, 2021 10:38 am

reporter   ~0063242

How odd. I had this issue in Classic Fusion, where a specific type of Forcefield has a galactic cap of 15, but it was always ignored and you could max out the per planet cap as many times as you wanted.

The code there is the same in both versions. Apparently it was solved sometime in-between...elsewhere? A search through release notes doesn't mention it, so maybe just by chance fixed in the refactor since the version CF is on and now.

Best result?

Chris_McElligottPark

Nov 8, 2021 4:54 pm

administrator   ~0063258

Looks fixed by tom to me when I check the code. Cheers!

Issue History

Date Modified Username Field Change
Oct 27, 2021 10:20 am RocketAssistedPuffin New Issue
Oct 27, 2021 10:21 am RocketAssistedPuffin Relationship added related to 0025390
Oct 27, 2021 10:31 am RocketAssistedPuffin Summary Galaxy wide build cap feature only works for Fleet Leaders. => Galaxy wide build cap feature seems to only works for Fleet Leaders.
Nov 2, 2021 6:27 pm tom.prince Note Added: 0063153
Nov 7, 2021 10:38 am RocketAssistedPuffin Note Added: 0063242
Nov 8, 2021 4:54 pm Chris_McElligottPark Assigned To => tom.prince
Nov 8, 2021 4:54 pm Chris_McElligottPark Status new => resolved
Nov 8, 2021 4:54 pm Chris_McElligottPark Resolution open => fixed
Nov 8, 2021 4:54 pm Chris_McElligottPark Note Added: 0063258