View Issue Details

IDProjectCategoryLast Update
0025436AI War 2SuggestionAug 3, 2021 11:31 am
ReporterExlium Assigned ToChris_McElligottPark  
Severitytrivial 
Status resolvedResolutionfixed 
Product Version3.313 Input, Selection, And Flagships 
Fixed in VersionBeta 3.502 Input Salve 
Summary0025436: Orders being on key-up is eating a lot of my inputs
DescriptionThis is a personal thing so I'm not sure if I'm the minority or not but I generally don't stop moving my mouse as I'm clicking around if I'm shift queueing orders or something along those lines. Obviously with the new inputs, if I move slightly before my mouse raises back up it just won't register the order. I don't think I've ever played a RTS where a non-held click would only register on key-up. I understand this change was made for people who wanted to pan the camera with right click so they could hold RMB and drag the screen around without a move order coming out but maybe make it an option at least so that people who still pan with MMB can have clean orders.

Here is a video of me just trying to queue orders in a circle around a planet. I'm probably clicking 2-3 times a second except for the time where I show how I have to stop completely to guarantee I get the order.

https://youtu.be/ywmk37d3SX4
TagsNo tags attached.

Relationships

related to 0025429 resolvedChris_McElligottPark Extremely annoying delay between right clicks 

Activities

RedPine

Jul 19, 2021 9:28 pm

reporter   ~0062520

I've never noticed that before, but now that you've pointed it out, it's REALLY annoying.

This would explain all those times where my ships didn't attack the thing I needed to attack, and why clicking on certain things is so finicky. I didn't know that the game only registers key up.

Exlium

Jul 20, 2021 3:03 pm

reporter   ~0062525

Ok so after some thought I realized that it being on key up is fine its just a matter of application. Its more so the precision aspect. I like the required precision of 20px for double clicking but the 60px requirement on right clicking can mess me up a lot and since I'm not panning with right click there is no upside to it for me.

BadgerBadger

Jul 20, 2021 4:37 pm

manager   ~0062527

AFAIK one person bound "Pan" to right click for no apparent reason. I'm not sure that such a weird config choice should be supported if it is a hassle for other people.

BadgerBadger

Jul 31, 2021 12:53 pm

manager   ~0062535

I don't like the current behaviour; I sometimes like to build things by clicking rapidly while moving my mouse. Between the "discard input with mouse movement" and "things happen on key-up" I can't do this at all.

I would prefer if both of these changes were reverted

Chris_McElligottPark

Aug 3, 2021 11:31 am

administrator   ~0062557

Thanks!

* Vastly updated the input code once again.
** First, there's no time limit related to single-clicks anymore. Mouseups, that is.
** Second, we now once again use mousedown for detecting when you click, rather than mouseup. That just feels way more responsive.
*** This does mean that, definitively, you can't bind something like the grab and pan to the right mouse button without it also triggering the right mouse click. You'll need to use the middle mouse button, or mouse4 or 5 if you have those.
** Third, In the mouse event handling code in particular, we now handle ALL of the events that come in a frame, which includes double-clicks and single-clicks from either button, all at once if needed. This is something that has a lot of common with the central windows pipeline pump, and should keep certain things from otherwise being blocked.
** Third, the way that we activate bandbox selection mode is a bit different now, and more responsive. There were some funky bits in the code in general that just needed to get ironed out.
** All in all, things just feel a lot more responsive now, and the double-clicking logic still works just fine.

Issue History

Date Modified Username Field Change
Jul 19, 2021 1:38 pm Exlium New Issue
Jul 19, 2021 1:54 pm Daniexpert Relationship added related to 0025429
Jul 19, 2021 9:28 pm RedPine Note Added: 0062520
Jul 20, 2021 3:03 pm Exlium Note Added: 0062525
Jul 20, 2021 4:37 pm BadgerBadger Note Added: 0062527
Jul 31, 2021 12:53 pm BadgerBadger Note Added: 0062535
Jul 31, 2021 12:53 pm BadgerBadger Assigned To => Chris_McElligottPark
Jul 31, 2021 12:53 pm BadgerBadger Status new => assigned
Aug 3, 2021 11:31 am Chris_McElligottPark Status assigned => resolved
Aug 3, 2021 11:31 am Chris_McElligottPark Resolution open => fixed
Aug 3, 2021 11:31 am Chris_McElligottPark Fixed in Version => Beta 3.502 Input Salve
Aug 3, 2021 11:31 am Chris_McElligottPark Note Added: 0062557