View Issue Details
| ID | Project | Category | Date Submitted | Last Update | |
|---|---|---|---|---|---|
| 0023466 | AI War 2 | Crash/Exception | Jul 24, 2020 5:31 pm | Aug 29, 2020 5:01 pm | |
| Reporter | Lord Of Nothing | Assigned To | Chris_McElligottPark | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 2.106 Immortals and Unresponsiveness | ||||
| Fixed in Version | 2.130 Civilian Industries | ||||
| Summary | 0023466: Error upon saving | ||||
| Description | Just ran into this in my current game - it had been fine up until now since the one with the astro trains was fixed- if I get a reproduction I will update, but given that making another save immediately afterwards in the same game without loading failed to give the same error, I am not optimistic. The save associated with the message is attached, for what it's worth. 7/24/2020 10:26:13 PM Tried to write Int16 PosExceptNeg1, but passed value was: -23492, which is out of range! Value set to -1 so your save would work. (Unknown field being saved) at System.Environment.get_StackTrace () [0x00000] in <1f0c1ef1ad524c38bbc5536809c46b48>:0 at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.DebugLogDestination Destination, System.Boolean IncludeStackTrace, Arcen.Universal.Verbosity Verbosity) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.DebugLogDestination Destination, Arcen.Universal.Verbosity Verbosity) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.Verbosity Verbosity) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.Universal.ArcenSerializationBuffer.AddInt16 (Arcen.Universal.ReadStyle RStyle, System.Int16 Item, System.String FieldNameForErrors) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.AIW2.Core.SpeedGroup.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.AIW2.Core.Faction.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.AIW2.Core.World_AIW2.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.Universal.World.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.Universal.World.SaveWorldToDisk (System.String SaveName, System.Collections.Generic.List`1[T] SavegameMetadata) [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.AIW2.External.GameCommand_SaveGame.Execute (Arcen.AIW2.Core.GameCommand command, Arcen.AIW2.Core.ArcenSimContext context) [0x00000] in <311aa6a26de94c80a7adb9ad857a7bae>:0 at Arcen.AIW2.Core.GameCommand.Execute (Arcen.AIW2.Core.ArcenSimContext Context) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.AIW2.Core.World_AIW2.OnClient_ExecuteGameCommandsReceivedFromServer (Arcen.AIW2.Core.ArcenSimContext Context) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.AIW2.External.SimPlannerImplementation.DoActualSimStep (System.Boolean& stalledWaitingOnConnections, System.Boolean& mayUpdateVisuals) [0x00000] in <311aa6a26de94c80a7adb9ad857a7bae>:0 at Arcen.AIW2.Core.Engine_AIW2.ProcessSimStep (System.Boolean& stalledWaitingOnConnections) [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at Arcen.Universal.Engine_Universal.OnUpdateFromMainThread () [0x00000] in <4cb092286fab4f19b49831ca6cddd610>:0 at Arcen.AIW2.Core.ArcenGameControllerBase.BaseUpdate () [0x00000] in <f1aca40f327f49a99c42dd75b818abba>:0 at ArcenGameController.Update () [0x00000] in <342846c60ad043638e2ec80b42611e65>:0 | ||||
| Tags | No tags attached. | ||||
| related to | 0023593 | resolved | Chris_McElligottPark | Occasional Exception |
| has duplicate | 0023610 | resolved | Chris_McElligottPark | Error message on saving. (Save still works fine.) |
| related to | 0023493 | resolved | Chris_McElligottPark | Tried to write Int16 PosExceptNeg1, but passed value was: -31018 |
|
|
|
|
|
It looks like there was a buffer overflow on speed group IDs, if I had to guess. This should be relatively harmless, although it's definitely annoying. |
|
|
Ah, thankfully we now have the debugging info from your 0023610, which is actually the same issue. Finally we'll get to the root of this! |
|
|
Thanks! * It is now possible that your logs will wind up having the message "BUG: overriding speed limit for group X to [a negative number below -1]. Overflow? Setting to -1 instead." ** If this is frequent, it may slow down your game, but the stack traces will let us know where we are going wrong and causing this to happen. ** We fixed one area where MAYBE this could be caused, but probably that was not possible in the place we fixed it. Most likely the problem is in something that is calling GameCommand_CreateSpeedGroup with a command.RelatedIntegers[0] that is greater than the 32767. *** With that in mind, anything that is larger than that being passed into that method is now automatically corrected down to 32766. This may lead to some turbo speed groups, not sure, but at least they won't be erroring... and that IS what the calling code is asking for, so maybe it's intentional? ** At the same time, in some other places in the code where it was checking to apply the speed only if it was "not -1", it is now checking to apply the speed limit if it is "greater than 0." This seems more like the correct intent, and hopefully won't break anything. ** And beyond that, prior to serialization, any speed groups with an OverrideSpeedLimit less than -1 will automatically just set their value to -1 silently and thus avoid popup errors that could be really annoying in savegames for folks. This has been an issue on and off since July 24th, apparently. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| Jul 24, 2020 5:31 pm | Lord Of Nothing | New Issue | |
| Jul 24, 2020 5:31 pm | Lord Of Nothing | File Added: 11.save | |
| Jul 24, 2020 5:31 pm | Lord Of Nothing | File Added: 11.savemet | |
| Jul 24, 2020 6:03 pm | Chris_McElligottPark | Note Added: 0057843 | |
| Aug 1, 2020 7:20 pm | Lord Of Nothing | Relationship added | related to 0023493 |
| Aug 29, 2020 4:14 pm | Chris_McElligottPark | Relationship added | has duplicate 0023610 |
| Aug 29, 2020 4:14 pm | Chris_McElligottPark | Assigned To | => Chris_McElligottPark |
| Aug 29, 2020 4:14 pm | Chris_McElligottPark | Status | new => assigned |
| Aug 29, 2020 4:14 pm | Chris_McElligottPark | Note Added: 0058265 | |
| Aug 29, 2020 4:15 pm | Chris_McElligottPark | Relationship added | related to 0023593 |
| Aug 29, 2020 5:01 pm | Chris_McElligottPark | Status | assigned => resolved |
| Aug 29, 2020 5:01 pm | Chris_McElligottPark | Resolution | open => fixed |
| Aug 29, 2020 5:01 pm | Chris_McElligottPark | Fixed in Version | => 2.130 Civilian Industries |
| Aug 29, 2020 5:01 pm | Chris_McElligottPark | Note Added: 0058278 |
