View Issue Details

IDProjectCategoryLast Update
0027165AI War 2GUIApr 26, 2022 10:08 pm
ReporterStrategic Sage Assigned ToChris_McElligottPark  
Severityminor 
Status resolvedResolutionfixed 
Product Version5.004 Misc Polish 
Fixed in Version5.005 Threat Properly Threatens 
Summary0027165: Threat counter has gone on vacation.
DescriptionTwo saves of mine to illustrate. One is Necromancer game which had over 300 threat last I looked. Now it says 2.

Second is a Logistician one. Says 0 threat. There is never 0 threat :). Ever.

The top resource bar threat counter is for some reason not counting right at the moment.
TagsNo tags attached.

Activities

Strategic Sage

Apr 25, 2022 5:21 am

reporter  

Diamonds.save (454,503 bytes)
Go.save (313,058 bytes)

Lord Of Nothing

Apr 25, 2022 8:26 am

reporter   ~0066425

Last edited: Apr 25, 2022 8:27 am

Very strange. I wonder if this is an overcorrection related to the change puffin made with regard to all this: https://discord.com/channels/240637654717300736/865219231092310066/967556522915819590 , where loads of stuff that wasn't threat was being counted as such. I don't know, but it's about the right time period. Or it could be a different error that's actually much older, but the massively inflated threat score from the linked issue has been hiding it's existence.

RocketAssistedPuffin

Apr 25, 2022 8:39 am

reporter   ~0066427

The change I did (actually just applying Badgers fix) was solely to AI Guards. I don't know how it could cause other things.

RocketAssistedPuffin

Apr 25, 2022 9:53 am

reporter   ~0066432

Last edited: Apr 25, 2022 10:06 am

Fix to the Strength Counting code again. The fix before to make Guards not count as threat, made it so only the AI Sentinels faction would. Hunter (and things like CPA faction ships) would get ignored by the top bar and galaxy filter. It now checks if the units faction is of FactionType.AI (as it did before), AND checks if the units faction is allied to the AI by default. If both are false, it's not an AI unit!

Badger, if there is a better way to do this, please feel free. I feel worried about Templar and Elderlings showing up because they are allied to the AI by default...though they don't appear to count.

Chris_McElligottPark

Apr 26, 2022 10:08 pm

administrator   ~0066486

Thanks to puffin for the fix!

Issue History

Date Modified Username Field Change
Apr 25, 2022 5:21 am Strategic Sage New Issue
Apr 25, 2022 5:21 am Strategic Sage File Added: Diamonds.save
Apr 25, 2022 5:21 am Strategic Sage File Added: Go.save
Apr 25, 2022 8:26 am Lord Of Nothing Note Added: 0066425
Apr 25, 2022 8:27 am Lord Of Nothing Note Edited: 0066425
Apr 25, 2022 8:39 am RocketAssistedPuffin Note Added: 0066427
Apr 25, 2022 9:53 am RocketAssistedPuffin Note Added: 0066432
Apr 25, 2022 10:06 am RocketAssistedPuffin Note Edited: 0066432
Apr 26, 2022 10:08 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Apr 26, 2022 10:08 pm Chris_McElligottPark Status new => resolved
Apr 26, 2022 10:08 pm Chris_McElligottPark Resolution open => fixed
Apr 26, 2022 10:08 pm Chris_McElligottPark Fixed in Version => 5.005 Threat Properly Threatens
Apr 26, 2022 10:08 pm Chris_McElligottPark Note Added: 0066486