View Issue Details

IDProjectCategoryLast Update
0025917AI War 2Gameplay IssueDec 16, 2021 4:37 pm
ReporterChris_McElligottPark Assigned ToChris_McElligottPark  
Severityminor 
Status resolvedResolutionfixed 
Fixed in VersionBeta 3.767 Elderling Sanity 
Summary0025917: Implement self-checking for central unit dictionary.
DescriptionI have a strong suspicion that units are not always in the central dictionary. This is borne out by the ghosts in multiplayer (those are not in the central dictionary, but still appear), and also by the FRD target "not in death registry" bug.

This is kind of a concerning bug, because it means I can't wholly trust the accuracy of the concurrent dictionary, but what I need to do is set up a background thread that just iterates over all the planetfactions and their units and makes sure all of them are in the central dictionary. If they're not, then add them in.

This should be something that I can run like the audio-processing-checks code in the modern codebase, and it should solve a ton of bugs going into multiplayer in particular.
TagsNo tags attached.

Relationships

child of 0025884 resolvedChris_McElligottPark Parent: Todo prior to beta exit 

Activities

Chris_McElligottPark

Dec 16, 2021 4:37 pm

administrator   ~0063476

* Added in a new PerSecondSimRepair thread that does checking for seeing if there are squads, shots, or wormholes missing in the main dictionary lookup that are in the entity collections of planet factions, which would be the normal genesis of the "ghosts" problem in multiplayer. As well as the "such and such missing from death registry" bug, too.
** So far nothing has happened, but it should self-correct any cases like that, if they still happen.

Issue History

Date Modified Username Field Change
Dec 14, 2021 4:54 pm Chris_McElligottPark New Issue
Dec 14, 2021 4:55 pm Chris_McElligottPark Relationship added child of 0025884
Dec 16, 2021 4:37 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Dec 16, 2021 4:37 pm Chris_McElligottPark Status new => resolved
Dec 16, 2021 4:37 pm Chris_McElligottPark Resolution open => fixed
Dec 16, 2021 4:37 pm Chris_McElligottPark Fixed in Version => Beta 3.767 Elderling Sanity
Dec 16, 2021 4:37 pm Chris_McElligottPark Note Added: 0063476