View Issue Details

IDProjectCategoryLast Update
0025632AI War 2Gameplay IssueOct 15, 2021 1:07 pm
ReporterDaniexpert Assigned ToChris_McElligottPark  
Severitymajor 
Status resolvedResolutionfixed 
Product VersionBeta 3.708 Bugfixes And Death Spawn 
Fixed in VersionBeta 3.710 Hotfixes Serialization and Performance 
Summary0025632: Necromancer hack possible bug
DescriptionIs this still a WiP or it's a bug? It says there are no units that can hack, but I have a necromancer right there.
TagsNo tags attached.

Activities

Daniexpert

Oct 14, 2021 10:18 am

manager  

2021-10-14 16_17_15-AIWar2.png (258,309 bytes)   
2021-10-14 16_17_15-AIWar2.png (258,309 bytes)   
hackTemplar.save (215,291 bytes)

Daniexpert

Oct 15, 2021 6:57 am

manager   ~0062940

Adding an usable save from 3.709
hackTemplar-2.save (211,757 bytes)

BadgerBadger

Oct 15, 2021 12:02 pm

manager   ~0062946

These are problems introduced in Chris' refactor of my code

Chris_McElligottPark

Oct 15, 2021 12:54 pm

administrator   ~0062947

Thanks! Part one.

* Fixed an issue with some of the new custom flagship types that made them unable to hack. This had broken the necromancer faction's ability to have their flagships hack, in particular.

Chris_McElligottPark

Oct 15, 2021 1:07 pm

administrator   ~0062948

Thanks!

* Removed the constructor on my custom version of List<> which took an IEnumerable collection. This was inefficient to begin with in Microsoft's version, and generally used to work around things like the limitations of "can't be iterating over a dictionary and add or remove to/from it" (we now can do that with my version of dictionary).
** In general, I am already planning on cracking down a lot on how collections are initialized and disposed for memory leak purposes in the very near future, so this is in line with my plans there, anyway.
** In the short term, more to the point, there was a bug in my version of the list that took a collection as an initializer, and this was likely causing some issues in xml parsing being fully applied (not confirmed, but it seems likely), and also definitely was causing the necromancer hacks to come up blank, and may have also messed with some of the scourge logic and two map types.

Issue History

Date Modified Username Field Change
Oct 14, 2021 10:18 am Daniexpert New Issue
Oct 14, 2021 10:18 am Daniexpert File Added: 2021-10-14 16_15_14-AIWar2.png
Oct 14, 2021 10:18 am Daniexpert File Added: 2021-10-14 16_17_15-AIWar2.png
Oct 14, 2021 10:18 am Daniexpert File Added: hackTemplar.save
Oct 15, 2021 6:57 am Daniexpert Note Added: 0062940
Oct 15, 2021 6:57 am Daniexpert File Added: hackTemplar-2.save
Oct 15, 2021 12:01 pm BadgerBadger Assigned To => Chris_McElligottPark
Oct 15, 2021 12:01 pm BadgerBadger Status new => assigned
Oct 15, 2021 12:02 pm BadgerBadger Note Added: 0062946
Oct 15, 2021 12:54 pm Chris_McElligottPark Note Added: 0062947
Oct 15, 2021 1:07 pm Chris_McElligottPark Status assigned => resolved
Oct 15, 2021 1:07 pm Chris_McElligottPark Resolution open => fixed
Oct 15, 2021 1:07 pm Chris_McElligottPark Fixed in Version => Beta 3.710 Hotfixes Serialization and Performance
Oct 15, 2021 1:07 pm Chris_McElligottPark Note Added: 0062948