View Issue Details
| ID | Project | Category | Date Submitted | Last Update | |
|---|---|---|---|---|---|
| 0025519 | AI War 2 | Gameplay Issue | Aug 17, 2021 1:37 pm | Aug 18, 2021 10:08 pm | |
| Reporter | Strategic Sage | Assigned To | Chris_McElligottPark | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | Beta 3.510 Threads And Science | ||||
| Fixed in Version | Beta 3.601 Tuning Before A Respite | ||||
| Summary | 0025519: Wave Factions Are Very Confused | ||||
| Description | When waves attack, they are soon considered 'Natural Objects'. The top-bar notifications consider them to be 'Border Aggression', but they're not - they come in as waves. Note the Smooth and Rough system in this save, and the impending wave about to hit Malignus. Both show this curious and amusing behavior. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
This looks like the factions themselves are confused. Presumably related to pooling |
|
|
Yes, I see the same thing happening: waves spawning as border aggression. Related to yesterday's discord conversation, this might be the reason for the extreme difficulty I was encoutering on difficulty 9 Tsunami AI. |
|
|
I'm working on this, and discussing it in the chris-talks-code discord channel, not that anyone has to go there. There's a mix of things here, some of them that are just tooltip errors, some of which are other errors yet to be determined. I'm not sure how much of this is pooling-related, we'll see. |
|
|
Also, I will note this: the save that Strategic Sage posted was started on 3.000, which is fine, but it looks like it had some intermediate saves after being played on some definitively-buggy versions. It may be that that save is corrupt, to be honest, and so I'm not sure that we can trust anything from it. I think that any save that has been saved between 3.500 and before 3.510 is one that will have all sorts of bugs and strangeness in it from being subtly or not-subtly corrupted. If a save is from prior to 3.500 and it was loaded in 3.510 or after, it should be fine. If a save was started after 3.510 or after, it should also be fine. Any saves that were saved in those intervening versions, I think I'm not going to chase any strange faction stuff, because those are known-bad and I 100% know data got scrambled and corrupted, so we're just seeing the echoes of that now. I'd need to see it broken in either an older or a newer save in order to verify that it's still a problem. I just ran that particular save above and it did break just as expected (natural objects spawned, then attacked me; I didn't see anything about border aggression). But I just started a new game on 3.600 and it worked perfectly. Sorry about the trouble of those intervening versions... |
|
|
Unfortunately I had what I reported in my previous comment in this ticket happening in a game freshly started today on 3.600 with DLC3 enabled, so I think there is some kind of issue regarding Border aggression. |
|
|
That makes sense! I'm not surprised something is still off, but I can't duplicate it myself yet. Can I have that save? |
|
|
Adding the aforementioned save from 3.600. Waves spawning in 3 seconds. |
|
|
I think I'm just going to copy/paste the Wave code into some new Border Aggression code. So border aggression will basically be a copy of waves. I am pretty okay with this, since it will allow for additional fine-tuning specific to border aggro |
|
|
Thanks! * Fixed a bug that was new as of the addition of the "border aggression" feature that we are testing out (it's not fully released yet). ** Essentially, we reused the relentless wave faction logic for the border aggression, and that meant that tests for "find the next relentless wave faction" would (sort of by luck of how a savegame was set up, the order of factions) sometimes come back with border aggression instead of relentless waves. ** This meant that waves would spawn as border aggression sometimes, but not always -- but always the same in a given save. ** This has been fixed by making these classes split, so that they have a common abstract core class with the real logic (which was the point -- not duplicating code), and then having unique actual end classes so that this confusion doesn't happen any more. ** This new design does mean that we can't use any static variables in the base abstract class unless they are also threadstatic, but we already were not doing that, so there's nothing more to change at this time. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| Aug 17, 2021 1:37 pm | Strategic Sage | New Issue | |
| Aug 17, 2021 1:37 pm | Strategic Sage | File Added: Waves.save | |
| Aug 17, 2021 6:11 pm | BadgerBadger | Note Added: 0062737 | |
| Aug 17, 2021 6:11 pm | BadgerBadger | Assigned To | => BadgerBadger |
| Aug 17, 2021 6:11 pm | BadgerBadger | Status | new => assigned |
| Aug 17, 2021 6:55 pm | BadgerBadger | Assigned To | BadgerBadger => Chris_McElligottPark |
| Aug 18, 2021 7:41 am | Daniexpert | Note Added: 0062745 | |
| Aug 18, 2021 11:08 am | Chris_McElligottPark | Note Added: 0062746 | |
| Aug 18, 2021 11:13 am | Chris_McElligottPark | Status | assigned => feedback |
| Aug 18, 2021 11:13 am | Chris_McElligottPark | Note Added: 0062747 | |
| Aug 18, 2021 11:19 am | Daniexpert | Note Added: 0062748 | |
| Aug 18, 2021 11:24 am | Chris_McElligottPark | Note Added: 0062749 | |
| Aug 18, 2021 11:28 am | Daniexpert | Note Added: 0062751 | |
| Aug 18, 2021 11:28 am | Daniexpert | File Added: Autosave at 23m 0s.save | |
| Aug 18, 2021 12:54 pm | BadgerBadger | Note Added: 0062752 | |
| Aug 18, 2021 10:08 pm | Chris_McElligottPark | Status | feedback => resolved |
| Aug 18, 2021 10:08 pm | Chris_McElligottPark | Resolution | open => fixed |
| Aug 18, 2021 10:08 pm | Chris_McElligottPark | Fixed in Version | => Beta 3.601 Tuning Before A Respite |
| Aug 18, 2021 10:08 pm | Chris_McElligottPark | Note Added: 0062757 |
