View Issue Details
| ID | Project | Category | Date Submitted | Last Update | |
|---|---|---|---|---|---|
| 0019541 | AI War 2 | GUI | Mar 29, 2018 10:29 am | Aug 29, 2018 7:46 pm | |
| Reporter | Chris_McElligottPark | Assigned To | Chris_McElligottPark | ||
| Severity | minor | ||||
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 0.759-0.760 Only The Start of Discovery | ||||
| Summary | 0019541: Hacking "Vague and mysterious reasons" denial is not good to say. | ||||
| Description | I put that in as a stopgap. Please search for this: //KEITH_TODO: "Vague and mysterious reasons" for hacking should move up to here, and be more specific. Things to do with that: 1. Right now, the !this.Type.Implementation.GetCanBeHacked( this.Target, hacker ) is being called AFTER we find a local hacker and if we're at that planet. But that's not helpful at all, because we're going to then bring a hacker to the planet and THEN find out we can't hack it because of some other reason. So we need to tell other reasons for being unable to hack BEFORE "there's nobody here to do the thing you can't do." ;) 2. Secondly, inside that GetCanBeHacked method, it has a variety of reasons it might not be allowed to hack. I just have it returning "vague and mysterious reasons," because I didn't want to overstep into that and refactor it so that it can return textual reasons for the user to see. But we do need to do that. | ||||
| Tags | No tags attached. | ||||
|
|
The primary reasons I think you can have hacking denied are A. not enough hacking points (which is obvious from the sidebar) and B. for design hacking, you already have that ship type C. for corruption hacking, the tech here has already been corrupted. Most of the other checks are catchalls for conditions that shouldn't happen (like "If the design template server has null for its ship type") |
|
|
Fair enough, but that list might be extended at some point, and at any rate those things need to move up the list to be shown first. I am not super concerned about it, but it does need to change. |
|
|
I believe this is handled now. If not, it will be my issue to fix. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| Mar 29, 2018 10:29 am | Chris_McElligottPark | New Issue | |
| Mar 29, 2018 10:29 am | Chris_McElligottPark | Status | new => assigned |
| Mar 29, 2018 10:29 am | Chris_McElligottPark | Assigned To | => keith.lamothe |
| Mar 29, 2018 11:09 am | BadgerBadger | Note Added: 0047315 | |
| Mar 29, 2018 11:45 am | Chris_McElligottPark | Note Added: 0047318 | |
| Aug 29, 2018 7:46 pm | Chris_McElligottPark | Assigned To | keith.lamothe => Chris_McElligottPark |
| Aug 29, 2018 7:46 pm | Chris_McElligottPark | Status | assigned => resolved |
| Aug 29, 2018 7:46 pm | Chris_McElligottPark | Resolution | open => fixed |
| Aug 29, 2018 7:46 pm | Chris_McElligottPark | Fixed in Version | => 0.759-0.760 Only The Start of Discovery |
| Aug 29, 2018 7:46 pm | Chris_McElligottPark | Note Added: 0048540 |
