View Issue Details

IDProjectCategoryLast Update
0002529AI War 1 / ClassicBug - OtherJan 18, 2011 10:33 am
Reportervonkolberg Assigned Tokeith.lamothe  
Status resolvedResolutionfixed 
Product Version4.070 
Summary0002529: 4.070 broke my savegame
DescriptionGot the following error message on loading a savegame made yesterday with 4.069... Everything not on my home planet had disappeared!!!


1/18/2011 10:12:07 AM (4.070)
-----------------------------------
Client Receiving Data Error-----------------------------------
System.NullReferenceException: Object reference not set to an instance of an object
  at ForegroundObject.ChaseObjectToKill (Int32 HitPercentToUse) [0x00000] in <filename unknown>:0
  at ForegroundObject.SetObjectToKill (.ForegroundObject Target, Boolean SetByPlayer, System.String Source, Boolean ClearDestination) [0x00000] in <filename unknown>:0
  at Game.ClientReceivingData (NetworkMessageType Type, System.String Message) [0x00000] in <filename unknown>:0

1/18/2011 10:13:04 AM (4.070)
-----------------------------------
Client Receiving Data Error-----------------------------------
System.NullReferenceException: Object reference not set to an instance of an object
  at ForegroundObject.ChaseObjectToKill (Int32 HitPercentToUse) [0x00000] in <filename unknown>:0
  at ForegroundObject.SetObjectToKill (.ForegroundObject Target, Boolean SetByPlayer, System.String Source, Boolean ClearDestination) [0x00000] in <filename unknown>:0
  at Game.ClientReceivingData (NetworkMessageType Type, System.String Message) [0x00000] in <filename unknown>:0

1/18/2011 10:14:19 AM (4.070)
-----------------------------------
Client Receiving Data Error-----------------------------------
System.NullReferenceException: Object reference not set to an instance of an object
  at ForegroundObject.ChaseObjectToKill (Int32 HitPercentToUse) [0x00000] in <filename unknown>:0
  at ForegroundObject.SetObjectToKill (.ForegroundObject Target, Boolean SetByPlayer, System.String Source, Boolean ClearDestination) [0x00000] in <filename unknown>:0
  at Game.ClientReceivingData (NetworkMessageType Type, System.String Message) [0x00000] in <filename unknown>:0
TagsNo tags attached.
Internal Weight

Activities

keith.lamothe

Jan 18, 2011 7:31 am

administrator   ~0009057

Making such a report and then not attaching your savegame... it's just cruel ;)

More seriously, if you post the savegame I may be able to reproduce the bug in my own environment and thus actually get a line number and indication of what specific thing was null that shouldn't have been.

keith.lamothe

Jan 18, 2011 7:44 am

administrator   ~0009059

Ok, I just did a search through the diffs between 4.069 and 4.070 and there was only one addition in that function and it was possible (though unlikely) for the field in question to be null. I've added a defensive null-check for 4.071.

But it would still be good if you could attach your savegame so I can test my fix against your actual situation.

Thanks for letting us know :)

vonkolberg

Jan 18, 2011 8:58 am

reporter  

new.sav (189,239 bytes)

vonkolberg

Jan 18, 2011 8:58 am

reporter   ~0009062

added the save file

Prezombie

Jan 18, 2011 10:12 am

reporter   ~0009064

Psst, in the future, finish your games before updating, new versions sometimes change how the AI units are distributed, making them more or less common and more or less weak. a savefile will only have the strength changes, not the number changes.

keith.lamothe

Jan 18, 2011 10:25 am

administrator   ~0009065

It depends on what you're trying to do. If you're trying to play a stable game (in terms of bugs and balance), it's generally best to stick to the official version. If you want to try the new stuff and (perhaps more importantly) help us test by catching and reporting bugs, the latest beta is typically best (but it's certainly a good idea to keep backups of the saves).

keith.lamothe

Jan 18, 2011 10:31 am

administrator   ~0009066

Ok, thanks very much for uploading the save, I was able to confirm that it died without the null-check, and works fine with it, so it should be fine in 4.071 which hopefully will be out sometime today.

vonkolberg

Jan 18, 2011 10:33 am

reporter   ~0009067

Thanks, great support as always!

Issue History

Date Modified Username Field Change
Jan 18, 2011 4:25 am vonkolberg New Issue
Jan 18, 2011 7:31 am keith.lamothe Note Added: 0009057
Jan 18, 2011 7:44 am keith.lamothe Note Added: 0009059
Jan 18, 2011 7:45 am keith.lamothe Status new => resolved
Jan 18, 2011 7:45 am keith.lamothe Resolution open => fixed
Jan 18, 2011 7:45 am keith.lamothe Assigned To => keith.lamothe
Jan 18, 2011 8:58 am vonkolberg File Added: new.sav
Jan 18, 2011 8:58 am vonkolberg Note Added: 0009062
Jan 18, 2011 10:12 am Prezombie Note Added: 0009064
Jan 18, 2011 10:25 am keith.lamothe Note Added: 0009065
Jan 18, 2011 10:31 am keith.lamothe Note Added: 0009066
Jan 18, 2011 10:33 am vonkolberg Note Added: 0009067