View Issue Details

IDProjectCategoryLast Update
0020791AI War 2[All Projects] GUIFeb 20, 2019 4:37 pm
ReporterDominus ArbitrationisAssigned ToBadgerBadger 
Severityminor 
Status resolvedResolutionfixed 
Product Version0.806 Sabre Company 
Fixed in Version0.814 Of Runaway AIs And Tech Cost Revamps 
Summary0020791: Route vs Controlled Systems lines are difficult to distinguish between
DescriptionThe difference between the color of link between two controlled systems light blue and the color of the "this is the route you will take" light blue is also extremely hard to make out.

Credit Delor on Steam https://steamcommunity.com/app/573410/discussions/0/2479690531137706730/
TagsNo tags attached.

Activities

nomad_delta

Dec 23, 2018 2:10 am

reporter   ~0050646

I'm experiencing the same issue -- came here to report the same problem and found this bug report already here. I'm attaching a screenshot (annotated with my text in yellow) to show what I see on my screen. The light blue color(s) used to show "controlled/friendly territory" versus military ship routing within explored territory are almost the exact same color, if not actually the exact same color... I actually can't tell.

controlled-vs-route.jpg (311,953 bytes)

BadgerBadger

Feb 7, 2019 4:00 pm

manager   ~0050789

This colour of those lines is determined by

    public abstract class BaseGalaxyMapDisplayMode : IGalaxyMapDisplayModeImplementation
    {
        public virtual Color GetColorForLinkBetweenPlanets(Planet FirstPlanet, Planet SecondPlanet)
        {
            ProjectedMultiPathData pathData = SpecialFaction_Human.NonSim_PlanetsInvolvedInPathToCurrentHoverPlanet_LocalFactionOnly;
            if ( pathData != null && pathData.GetAreConnected( FirstPlanet, SecondPlanet ) )
                return World_AIW2.Instance.GetLocalPlayerFaction().TeamCenterColor.TeamColorHighlighted; <======


That value is from
TeamColorDefinition.cs
                TypeDataObject.TeamColorHighlighted = ColorMath.AdjustBrightness0To1( TypeDataObject.TeamColor, 0.4f );
or
                TypeDataObject.TeamColorHighlighted = ColorMath.AdjustBrightness0To1( TypeDataObject.TeamColor, -0.3f );

This isn't sufficient differentiation.

BadgerBadger

Feb 20, 2019 1:11 pm

manager   ~0050823

DarkArchon suggests that actually changing the link width as well would be desirable, but I'm not sure how to do that. I think that's in the core visualization project and I'm not going to chase that right now.

nomad_delta

Feb 20, 2019 1:58 pm

reporter   ~0050824

I agree strongly with the suggestion to make the line width larger (bolder) as well as changing the color to indicate the currently selected or shown route or path, that would help a lot. I think even more important is just the fact that currently routes/paths outside of "known space" don't show *at all*, at least not for scouts, haven't checked in a while for other ships/fleets.

darkarchon

Feb 20, 2019 3:31 pm

reporter   ~0050825

Thickness implementation for AIW2, code changes here in text form as talked to BadgerBadger. Attaching GalaxyMapDisplayMode_Normal.cs as well

ArcenAIW2Visualization.dll

GalaxyMapPlanetLinkBase.cs
public abstract class GalaxyMapPlanetLinkBase
{
    [...]
    public abstract void SetThicknessMultiplier(float multiplier);
}

GalaxyMapPlanetLink.cs
public class GalaxyMapPlanetLink : GalaxyMapPlanetLinkBase
{
    [...]
    private float thicknessMultiplier = 1.0f;
    [...]
    
    public override void RenderLink()
    {
        [...]
        float num = 1.5f * thicknessMultiplier;
        [...]
    }
    
    public override void SetThicknessMultiplier(float multiplier)
    {
        this.thicknessMultiplier = multiplier;
    }
}

---

ArcenAIW2Core.dll

IGalaxyMapDisplayModeImplementation.cs
public interface IGalaxyMapDisplayModeImplementation
{
    [...]
    
    float GetThicknessMultiplierForLinkBetweenPlanets(Planet FirstPlanet, Planet SecondPlanet);
}

Planet.cs
public void UpdateVisualObj(bool IsCurrentPlanet, bool IsTextHidden, bool AreIconsHidden)
{
    [...]
    Color color = !galaxyMapLine.HumansHaveAnyKnowledgeOf ? Planet.grayColor : implementation.GetColorForLinkBetweenPlanets(galaxyMapLine.PlanetOne, galaxyMapLine.PlanetTwo);
    galaxyMapLine.SetThicknessMultiplier(implementation.GetThicknessMultiplierForLinkBetweenPlanets(galaxyMapLine.PlanetOne, galaxyMapLine.PlanetTwo));
    [...]
}

---

AIWarExternalVisualizationCode.dll

GalaxyMapDisplayMode_Normal.cs
public abstract class BaseGalaxyMapDisplayMode : IGalaxyMapDisplayModeImplementation
{
    [...]
    
    public virtual float GetThicknessMultiplierForLinkBetweenPlanets(Planet FirstPlanet, Planet SecondPlanet)
    {
        ProjectedMultiPathData localFactionOnly = SpecialFaction_Human.NonSim_PlanetsInvolvedInPathToCurrentHoverPlanet_LocalFactionOnly;
        if (localFactionOnly != null && localFactionOnly.GetAreConnected(FirstPlanet, SecondPlanet))
            return 3.0f;
        return 1.0f;
    }
}

GalaxyMapDisplayMode_Normal.cs (16,033 bytes)

BadgerBadger

Feb 20, 2019 4:37 pm

manager   ~0050826

Fixed! 100% credit for this fix goes to DarkArchon

BadgerBadger

Feb 20, 2019 4:37 pm

manager   ~0050827

Woo

Issue History

Date Modified Username Field Change
Nov 19, 2018 12:17 pm Dominus Arbitrationis New Issue
Nov 19, 2018 12:17 pm Dominus Arbitrationis Status new => assigned
Nov 19, 2018 12:17 pm Dominus Arbitrationis Assigned To => x4000Bughunter
Dec 23, 2018 2:10 am nomad_delta File Added: controlled-vs-route.jpg
Dec 23, 2018 2:10 am nomad_delta Note Added: 0050646
Feb 7, 2019 4:00 pm BadgerBadger Note Added: 0050789
Feb 20, 2019 1:11 pm BadgerBadger Note Added: 0050823
Feb 20, 2019 1:58 pm nomad_delta Note Added: 0050824
Feb 20, 2019 3:31 pm darkarchon File Added: GalaxyMapDisplayMode_Normal.cs
Feb 20, 2019 3:31 pm darkarchon Note Added: 0050825
Feb 20, 2019 4:37 pm BadgerBadger Note Added: 0050826
Feb 20, 2019 4:37 pm BadgerBadger Assigned To x4000Bughunter => BadgerBadger
Feb 20, 2019 4:37 pm BadgerBadger Status assigned => resolved
Feb 20, 2019 4:37 pm BadgerBadger Resolution open => fixed
Feb 20, 2019 4:37 pm BadgerBadger Fixed in Version => 0.814 Of Runaway AIs And Tech Cost Revamps
Feb 20, 2019 4:37 pm BadgerBadger Note Added: 0050827